Skip to content

Commit

Permalink
[tcp] Do not send RST for unrecognised connections
Browse files Browse the repository at this point in the history
On large networks with substantial numbers of monitoring agents,
unwanted TCP connection attempts may end up flooding iPXE's ARP cache.

Fix by silently dropping packets received for unrecognised TCP
connections.  This should not cause problems, since many firewalls
will also silently drop any such packets.

Reported-by: Jarrod Johnson <jarrod.b.johnson@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Jul 12, 2013
1 parent 936134e commit 18d0818
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/net/tcp.c
Expand Up @@ -1218,7 +1218,6 @@ static int tcp_rx ( struct io_buffer *iobuf,

/* If no connection was found, send RST */
if ( ! tcp ) {
tcp_xmit_reset ( tcp, st_src, tcphdr );
rc = -ENOTCONN;
goto discard;
}
Expand Down

0 comments on commit 18d0818

Please sign in to comment.