[tls] Fix uninitialised variable

mcb30 · mcb30 · commit 1e199c82601a · 2012-09-28T10:52:17.000+01:00
Reported-by: Christian Hesse &lt;list@eworm.de&gt;
Signed-off-by: Michael Brown &lt;mcb30@ipxe.org&gt;
diff --git a/src/net/tls.c b/src/net/tls.c
@@ -1773,8 +1773,7 @@ static int tls_new_record ( struct tls_session *tls, unsigned int type,
 	}
 
 	/* Handle record and free I/O buffer */
-	if ( handler )
-		rc = handler ( tls, iobuf->data, iob_len ( iobuf ) );
+	rc = ( handler ? handler ( tls, iobuf->data, iob_len ( iobuf ) ) : 0 );
 	free_iob ( iobuf );
 	return rc;
 }

Original file line number	Diff line number	Diff line change
`@@ -1773,8 +1773,7 @@ static int tls_new_record ( struct tls_session *tls, unsigned int type,`
`1773`	`1773`	`}`
`1774`	`1774`
`1775`	`1775`	`/* Handle record and free I/O buffer */`
`1776`		`- if ( handler )`
`1777`		`- rc = handler ( tls, iobuf->data, iob_len ( iobuf ) );`
	`1776`	`+ rc = ( handler ? handler ( tls, iobuf->data, iob_len ( iobuf ) ) : 0 );`
`1778`	`1777`	`free_iob ( iobuf );`
`1779`	`1778`	`return rc;`
`1780`	`1779`	`}`