[rtl8139] Perform only 8-bit ioport access on the ChipCmd register

Julian Pidancet · mcb30 · commit 91dd64ad25ba · 2011-11-14T22:23:06.000Z
The ChipCmd register is only an 8-bit register.  The 16-bit access
used by iPXE was causing an issue when used with qemu emulated rtl8139
device which was improperly aligning IOs.

Signed-off-by: Julian Pidancet &lt;julian.pidancet@gmail.com&gt;
Signed-off-by: Michael Brown &lt;mcb30@ipxe.org&gt;
diff --git a/src/drivers/net/rtl8139.c b/src/drivers/net/rtl8139.c
@@ -434,7 +434,7 @@ static void rtl_poll ( struct net_device *netdev ) {
 	}
 
 	/* Handle received packets */
-	while ( ! ( inw ( rtl->ioaddr + ChipCmd ) & RxBufEmpty ) ) {
+	while ( ! ( inb ( rtl->ioaddr + ChipCmd ) & RxBufEmpty ) ) {
 		rx_status = * ( ( uint16_t * )
 				( rtl->rx.ring + rtl->rx.offset ) );
 		rx_len = * ( ( uint16_t * )

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ static void rtl_poll ( struct net_device *netdev ) {`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`/* Handle received packets */`
`437`		`- while ( ! ( inw ( rtl->ioaddr + ChipCmd ) & RxBufEmpty ) ) {`
	`437`	`+ while ( ! ( inb ( rtl->ioaddr + ChipCmd ) & RxBufEmpty ) ) {`
`438`	`438`	`rx_status = * ( ( uint16_t * )`
`439`	`439`	`( rtl->rx.ring + rtl->rx.offset ) );`
`440`	`440`	`rx_len = * ( ( uint16_t * )`