Skip to content

Commit

Permalink
[serial] Enable UART FIFOs
Browse files Browse the repository at this point in the history
Escape sequences received via the serial console can fail since the
cpu_nap() in getchar_timeout() can delay processing for more than the
time it takes for a single character to arrive.

Fix by enabling the UART FIFOs.

Modified-by: Michael Brown <mcb30@ipxe.org>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
ppickfor authored and mcb30 committed Apr 22, 2014
1 parent 2788429 commit d644ad4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/serial.c
Expand Up @@ -204,8 +204,8 @@ static void serial_init ( void ) {
/* disable interrupts */
uart_writeb(0x0, UART_BASE + UART_IER);

/* disable fifo's */
uart_writeb(0x00, UART_BASE + UART_FCR);
/* enable fifos */
uart_writeb(0x01, UART_BASE + UART_FCR);

/* Set clear to send, so flow control works... */
uart_writeb((1<<1), UART_BASE + UART_MCR);
Expand Down

0 comments on commit d644ad4

Please sign in to comment.