[tls] Fix wrong memset in function tls_clear_cipher

stweil · mcb30 · commit dcccb1fb7bb7 · 2012-04-10T13:14:15.000+01:00
sizeof(cipherspec) is obviously wrong in this context, because it will
only zero the first 4 or 8 bytes (cipherspec is a pointer).

This problem was reported by cppcheck.

Signed-off-by: Stefan Weil &lt;sw@weilnetz.de&gt;
Signed-off-by: Michael Brown &lt;mcb30@ipxe.org&gt;
diff --git a/src/net/tls.c b/src/net/tls.c
@@ -594,7 +594,7 @@ static void tls_clear_cipher ( struct tls_session *tls __unused,
 			       cipherspec->pubkey_ctx );
 	}
 	free ( cipherspec->dynamic );
-	memset ( cipherspec, 0, sizeof ( cipherspec ) );
+	memset ( cipherspec, 0, sizeof ( *cipherspec ) );
 	cipherspec->suite = &tls_cipher_suite_null;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -594,7 +594,7 @@ static void tls_clear_cipher ( struct tls_session *tls __unused,`
`594`	`594`	`cipherspec->pubkey_ctx );`
`595`	`595`	`}`
`596`	`596`	`free ( cipherspec->dynamic );`
`597`		`- memset ( cipherspec, 0, sizeof ( cipherspec ) );`
	`597`	`+ memset ( cipherspec, 0, sizeof ( *cipherspec ) );`
`598`	`598`	`cipherspec->suite = &tls_cipher_suite_null;`
`599`	`599`	`}`
`600`	`600`