Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[usb] Add USB_INTERRUPT_OUT internal type
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed May 11, 2015
1 parent 86aa959 commit 0eaa3a3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
3 changes: 2 additions & 1 deletion src/drivers/bus/usb.c
Expand Up @@ -265,7 +265,8 @@ int usb_endpoint_described ( struct usb_endpoint *ep,
burst = ( descx ? descx->burst : USB_ENDPOINT_BURST ( sizes ) );

/* Calculate interval */
if ( type == USB_INTERRUPT ) {
if ( ( type & USB_ENDPOINT_ATTR_TYPE_MASK ) ==
USB_ENDPOINT_ATTR_INTERRUPT ) {
if ( port->speed >= USB_SPEED_HIGH ) {
/* 2^(desc->interval-1) is a microframe count */
interval = ( 1 << ( desc->interval - 1 ) );
Expand Down
2 changes: 1 addition & 1 deletion src/drivers/usb/usbhub.c
Expand Up @@ -425,7 +425,7 @@ static int hub_probe ( struct usb_function *func,

/* Locate interrupt endpoint descriptor */
if ( ( rc = usb_endpoint_described ( &hubdev->intr, config, interface,
USB_INTERRUPT, 0 ) ) != 0 ) {
USB_INTERRUPT_IN, 0 ) ) != 0 ) {
DBGC ( hubdev, "HUB %s could not describe interrupt endpoint: "
"%s\n", hubdev->name, strerror ( rc ) );
goto err_endpoint;
Expand Down
2 changes: 1 addition & 1 deletion src/drivers/usb/usbnet.c
Expand Up @@ -185,7 +185,7 @@ static int usbnet_comms_describe ( struct usbnet_device *usbnet,

/* Describe interrupt endpoint */
if ( ( rc = usb_endpoint_described ( &usbnet->intr, config,
desc, USB_INTERRUPT,
desc, USB_INTERRUPT_IN,
0 ) ) != 0 )
continue;

Expand Down
7 changes: 5 additions & 2 deletions src/include/ipxe/usb.h
Expand Up @@ -277,8 +277,11 @@ struct usb_endpoint_descriptor {
/** Bulk IN endpoint (internal) type */
#define USB_BULK_IN ( USB_ENDPOINT_ATTR_BULK | USB_DIR_IN )

/** Interrupt endpoint (internal) type */
#define USB_INTERRUPT ( USB_ENDPOINT_ATTR_INTERRUPT | USB_DIR_IN )
/** Interrupt IN endpoint (internal) type */
#define USB_INTERRUPT_IN ( USB_ENDPOINT_ATTR_INTERRUPT | USB_DIR_IN )

/** Interrupt OUT endpoint (internal) type */
#define USB_INTERRUPT_OUT ( USB_ENDPOINT_ATTR_INTERRUPT | USB_DIR_OUT )

/** USB endpoint MTU */
#define USB_ENDPOINT_MTU(sizes) ( ( (sizes) >> 0 ) & 0x07ff )
Expand Down

0 comments on commit 0eaa3a3

Please sign in to comment.