Navigation Menu

Skip to content

Commit

Permalink
[build] Eliminate unused sections at link-time
Browse files Browse the repository at this point in the history
Use -ffunction-sections, -fdata-sections, and --gc-sections to
automatically prune out any unreferenced sections.

This saves around 744 bytes (uncompressed) from the rtl8139.rom build.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Feb 22, 2011
1 parent f3c7266 commit 623469d
Show file tree
Hide file tree
Showing 6 changed files with 37 additions and 10 deletions.
13 changes: 13 additions & 0 deletions src/Makefile.housekeeping
Expand Up @@ -415,6 +415,19 @@ CFLAGS += -finstrument-functions
CFLAGS += -finstrument-functions-exclude-file-list=core/fnrec.c
endif

# Enable per-item sections and section garbage collection. Note that
# some older versions of gcc support -fdata-sections but treat it as
# implying -fno-common, which would break our build.
#
ifeq ($(CCTYPE),gcc)
DS_TEST = $(ECHO) 'char x;' | \
$(CC) -fdata-sections -S -x c - -o - 2>/dev/null | \
grep -E '\.comm' > /dev/null
DS_FLAGS := $(shell $(DS_TEST) && $(ECHO) '-fdata-sections')
CFLAGS += -ffunction-sections $(DS_FLAGS)
endif
LDFLAGS += --gc-sections

# compiler.h is needed for our linking and debugging system
#
CFLAGS += -include compiler.h
Expand Down
8 changes: 6 additions & 2 deletions src/arch/i386/scripts/i386-kir.lds
Expand Up @@ -68,7 +68,8 @@ SECTIONS {

.text16 : AT ( _text16_load_offset + __text16 ) {
__text16 = .;
*(.text.null_trap)
KEEP(*(.text.null_trap))
KEEP(*(.text.null_trap.*))
*(.text16)
*(.text16.*)
*(.text)
Expand Down Expand Up @@ -97,7 +98,7 @@ SECTIONS {
*(.data16.*)
*(.data)
*(.data.*)
*(SORT(.tbl.*)) /* Various tables. See include/tables.h */
KEEP(*(SORT(.tbl.*))) /* Various tables. See include/tables.h */
_edata16_progbits = .;
}
.bss16 : AT ( _data16_load_offset + __bss16 ) {
Expand Down Expand Up @@ -129,8 +130,11 @@ SECTIONS {

/DISCARD/ : {
*(.comment)
*(.comment.*)
*(.note)
*(.note.*)
*(.discard)
*(.discard.*)
}

/*
Expand Down
14 changes: 9 additions & 5 deletions src/arch/i386/scripts/i386.lds
Expand Up @@ -49,7 +49,8 @@ SECTIONS {

.text16.early 0x0 : AT ( _text16_early_lma ) {
_text16 = .;
*(.text16.null)
KEEP(*(.text16.null))
KEEP(*(.text16.null.*))
. += 1; /* Prevent NULL being valid */
*(.text16.early)
*(.text16.early.*)
Expand Down Expand Up @@ -98,15 +99,16 @@ SECTIONS {

.textdata 0x0 : AT ( _textdata_lma ) {
_textdata = .;
*(.text.null_trap)
KEEP(*(.text.null_trap))
KEEP(*(.text.null_trap.*))
. += 1; /* Prevent NULL being valid */
*(.text)
*(.text.*)
*(.rodata)
*(.rodata.*)
*(.data)
*(.data.*)
*(SORT(.tbl.*)) /* Various tables. See include/tables.h */
KEEP(*(SORT(.tbl.*))) /* Various tables. See include/tables.h */
_mtextdata = .;
} .bss.textdata (NOLOAD) : AT ( _end_lma ) {
*(.bss)
Expand All @@ -126,8 +128,8 @@ SECTIONS {

.zinfo 0x0 : AT ( _zinfo_lma ) {
_zinfo = .;
*(.zinfo)
*(.zinfo.*)
KEEP(*(.zinfo))
KEEP(*(.zinfo.*))
_mzinfo = .;
} .bss.zinfo (NOLOAD) : AT ( _end_lma ) {
_ezinfo = .;
Expand All @@ -143,6 +145,7 @@ SECTIONS {
.weak 0x0 : AT ( _end_lma ) {
_weak = .;
*(.weak)
*(.weak.*)
_eweak = .;
}
_assert = ASSERT ( ( _weak == _eweak ), ".weak is non-zero length" );
Expand All @@ -165,6 +168,7 @@ SECTIONS {
*(.einfo)
*(.einfo.*)
*(.discard)
*(.discard.*)
}

/*
Expand Down
4 changes: 3 additions & 1 deletion src/arch/i386/scripts/linux.lds
Expand Up @@ -51,7 +51,7 @@ SECTIONS {
_data = .;
*(.data)
*(.data.*)
*(SORT(.tbl.*)) /* Various tables. See include/tables.h */
KEEP(*(SORT(.tbl.*)))
_edata = .;
}

Expand All @@ -77,6 +77,7 @@ SECTIONS {
.weak 0x0 : {
_weak = .;
*(.weak)
*(.weak.*)
_eweak = .;
}
_assert = ASSERT ( ( _weak == _eweak ), ".weak is non-zero length" );
Expand All @@ -97,5 +98,6 @@ SECTIONS {
*(.rel)
*(.rel.*)
*(.discard)
*(.discard.*)
}
}
4 changes: 3 additions & 1 deletion src/arch/x86/scripts/efi.lds
Expand Up @@ -54,7 +54,7 @@ SECTIONS {
_data = .;
*(.data)
*(.data.*)
*(SORT(.tbl.*)) /* Various tables. See include/tables.h */
KEEP(*(SORT(.tbl.*))) /* Various tables. See include/tables.h */
_edata = .;
}

Expand All @@ -80,6 +80,7 @@ SECTIONS {
.weak 0x0 : {
_weak = .;
*(.weak)
*(.weak.*)
_eweak = .;
}
_assert = ASSERT ( ( _weak == _eweak ), ".weak is non-zero length" );
Expand All @@ -102,5 +103,6 @@ SECTIONS {
*(.einfo)
*(.einfo.*)
*(.discard)
*(.discard.*)
}
}
4 changes: 3 additions & 1 deletion src/arch/x86_64/scripts/linux.lds
Expand Up @@ -51,7 +51,7 @@ SECTIONS {
_data = .;
*(.data)
*(.data.*)
*(SORT(.tbl.*)) /* Various tables. See include/tables.h */
KEEP(*(SORT(.tbl.*)))
_edata = .;
}

Expand All @@ -77,6 +77,7 @@ SECTIONS {
.weak 0x0 : {
_weak = .;
*(.weak)
*(.weak.*)
_eweak = .;
}
_assert = ASSERT ( ( _weak == _eweak ), ".weak is non-zero length" );
Expand All @@ -97,5 +98,6 @@ SECTIONS {
*(.rel)
*(.rel.*)
*(.discard)
*(.discard.*)
}
}

0 comments on commit 623469d

Please sign in to comment.