Skip to content

Commit

Permalink
[hermon] Add missing __attribute__ (( packed ))
Browse files Browse the repository at this point in the history
On 64-bit builds, MLX_DECLARE_STRUCT() produces a structure that is
always a multiple of 64 bits long, causing the HCR structure to be
over-length by one dword.  This in turn causes hermon_cmd() to write
beyond the end of the HCR, which causes commands to fail.

Reported-by: Itay Gazit <itayg@mellanox.co.il>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Feb 17, 2011
1 parent 0e878b3 commit e8c636f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/drivers/infiniband/mlx_bitops.h
Expand Up @@ -46,8 +46,8 @@ typedef unsigned char pseudo_bit_t;
uint8_t bytes[ sizeof ( struct _structure ## _st ) / 8 ]; \
uint32_t dwords[ sizeof ( struct _structure ## _st ) / 32 ]; \
struct _structure ## _st *dummy[0]; \
} u; \
}
} __attribute__ (( packed )) u; \
} __attribute__ (( packed ))

/** Get pseudo_bit_t structure type from wrapper structure pointer */
#define MLX_PSEUDO_STRUCT( _ptr ) \
Expand Down

0 comments on commit e8c636f

Please sign in to comment.