[xen] Use standard calling pattern for asprintf()

Our asprintf() implementation guarantees that strp will be NULL on allocation failure, but this is not standard behaviour. Detect errors by checking for a negative return value instead of a NULL pointer. Signed-off-by: Michael Brown <mcb30@ipxe.org>
ipxe · Mar 22, 2017 · 01496a5 · 01496a5
1 parent 21d8624
commit 01496a5
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/interface/xen/xenstore.c b/src/interface/xen/xenstore.c
@@ -538,8 +538,7 @@ void xenstore_dump ( struct xen_hypervisor *xen, const char *key ) {
 		      child += ( strlen ( child ) + 1 /* NUL */ ) ) {
 
 			/* Construct child key */
-			asprintf ( &child_key, "%s/%s", key, child );
-			if ( ! child_key ) {
+			if ( asprintf ( &child_key, "%s/%s", key, child ) < 0 ){
 				DBGC ( xen, "XENSTORE could not allocate child "
 				       "key \"%s/%s\"\n", key, child );
 				rc = -ENOMEM;