Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[usb] Improve debug messages for failed control transactions
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Mar 23, 2015
1 parent b418af2 commit 026b344
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/drivers/bus/usb.c
Expand Up @@ -708,10 +708,6 @@ static void usb_control_complete ( struct usb_endpoint *ep,
/* Record completion status in buffer */
pshdr = iob_push ( iobuf, sizeof ( *pshdr ) );
pshdr->rc = rc;
if ( rc != 0 ) {
DBGC ( usb, "USB %s control transaction failed: %s\n",
usb->name, strerror ( rc ) );
}

/* Add to list of completed I/O buffers */
list_add_tail ( &iobuf->list, &usb->complete );
Expand Down Expand Up @@ -793,6 +789,9 @@ int usb_control ( struct usb_device *usb, unsigned int request,

/* Fail immediately if completion was in error */
if ( rc != 0 ) {
DBGC ( usb, "USB %s control %04x:%04x:%04x "
"failed: %s\n", usb->name, request,
value, index, strerror ( rc ) );
free_iob ( cmplt );
return rc;
}
Expand All @@ -809,8 +808,8 @@ int usb_control ( struct usb_device *usb, unsigned int request,
mdelay ( 1 );
}

DBGC ( usb, "USB %s timed out waiting for control transaction\n",
usb->name );
DBGC ( usb, "USB %s timed out waiting for control %04x:%04x:%04x\n",
usb->name, request, value, index );
return -ETIMEDOUT;

err_message:
Expand Down

0 comments on commit 026b344

Please sign in to comment.