[eoib] Avoid passing a NULL I/O buffer to netdev_tx_complete_err()

Report errors in eoib_duplicate() via netdev_tx_err() rather than netdev_tx_complete_err(), since netdev_tx_complete_err() accepts only valid I/O buffers that are currently in the network device's transmit queue. Signed-off-by: Michael Brown <mcb30@ipxe.org>
ipxe · Mar 21, 2017 · 1ec2a60 · 1ec2a60
1 parent 64de7dc
commit 1ec2a60
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/drivers/net/eoib.c b/src/drivers/net/eoib.c
@@ -870,8 +870,9 @@ static void eoib_duplicate ( struct eoib_device *eoib,
 
  err_post_send:
  err_path:
+	list_del ( &copy->list );
  err_alloc:
-	netdev_tx_complete_err ( netdev, copy, rc );
+	netdev_tx_err ( netdev, copy, rc );
 }
 
 /**