Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[build] Fix ARM32 EFI builds with current EDK2 headers
EDK2 commit 6440385 ("MdePkg/Include: Add enumeration size checks to
Base.h") enforced the UEFI specification mandate that enums should
always be 32 bits.  This revealed a latent bug in iPXE, which does not
build with -fno-short-enums.

Fix by adding -fno-short-enums to CFLAGS for ARM32 EFI builds.

Reported-by: Benjamin S. Allen <bsallen@alcf.anl.gov>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Jul 28, 2017
1 parent 1a77466 commit 8866c91
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/arch/arm32/Makefile.efi
@@ -1,5 +1,9 @@
# -*- makefile -*- : Force emacs to use Makefile mode

# UEFI requires that enums are always 32 bits
#
CFLAGS += -fno-short-enums

# Specify EFI image builder
#
ELF2EFI = $(ELF2EFI32)
Expand Down

0 comments on commit 8866c91

Please sign in to comment.