[rtl818x] Fix resource leak on error path

Signed-off-by: Michael Brown <mcb30@ipxe.org>
ipxe · Mar 23, 2017 · ce240c8 · ce240c8
1 parent c24f772
commit ce240c8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/drivers/net/rtl818x/rtl818x.c b/src/drivers/net/rtl818x/rtl818x.c
@@ -663,15 +663,17 @@ int rtl818x_probe(struct pci_device *pdev )
 	hwinfo = zalloc(sizeof(*hwinfo));
 	if (!hwinfo) {
 		DBG("rtl818x: hwinfo alloc failed\n");
-		return -ENOMEM;
+		err = -ENOMEM;
+		goto err_alloc_hwinfo;
 	}
 
 	adjust_pci_device(pdev);
 
 	dev = net80211_alloc(sizeof(*priv));
 	if (!dev) {
 		DBG("rtl818x: net80211 alloc failed\n");
-		return -ENOMEM;
+		err = -ENOMEM;
+		goto err_alloc_dev;
 	}
 
 	priv = dev->priv;
@@ -816,7 +818,9 @@ int rtl818x_probe(struct pci_device *pdev )
  err_free_dev:
 	pci_set_drvdata(pdev, NULL);
 	net80211_free(dev);
+ err_alloc_dev:
 	free(hwinfo);
+ err_alloc_hwinfo:
 	return err;
 }