Skip to content

Commit

Permalink
[crypto] Accept UTCTime/GeneralizedTime with no "seconds" field
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed May 21, 2012
1 parent f4c88d5 commit f20c374
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/crypto/asn1.c
Expand Up @@ -655,10 +655,16 @@ int asn1_generalized_time ( const struct asn1_cursor *cursor, time_t *time ) {
}

/* Parse digit string a pair at a time */
memset ( &pairs, 0, sizeof ( pairs ) );
data = contents.data;
remaining = contents.len;
for ( i = ( have_century ? 0 : 1 ) ; i < sizeof ( pairs.raw ) ; i++ ) {
if ( remaining < 2 ) {
/* Some certificates violate the X.509 RFC by
* omitting the "seconds" value.
*/
if ( i == ( sizeof ( pairs.raw ) - 1 ) )
break;
DBGC ( cursor, "ASN1 %p invalid time:\n", cursor );
DBGC_HDA ( cursor, 0, cursor->data, cursor->len );
return -EINVAL_ASN1_TIME;
Expand Down

0 comments on commit f20c374

Please sign in to comment.