Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[build] Pad .hd image type to 32 KB
The disk partition prefix code in hdprefix.S reads the gPXE image in
tracks, not individual sectors.  This means it will attempt to read
beyond the end of the image if the .hd image type is not padded to 32
KB.

This issue is affects virtualization software which may execute a .hd or
.usb image file directly - effectively running a machine with a tiny
disk containing just the gPXE image.  Boot will fail when gPXE tries to
read beyond the end of disk.
  • Loading branch information
stefanha committed Dec 15, 2009
1 parent 2eeb711 commit 9760005
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/arch/i386/Makefile.pcbios
Expand Up @@ -31,7 +31,7 @@ MEDIA += exe
#
PAD_rom = $(PADIMG) --blksize=512 --byte=0xff $@
PAD_dsk = $(PADIMG) --blksize=512 $@
PAD_hd = $(PADIMG) --blksize=512 $@
PAD_hd = $(PADIMG) --blksize=32768 $@

# rule to make a non-emulation ISO boot image
NON_AUTO_MEDIA += iso
Expand Down

0 comments on commit 9760005

Please sign in to comment.