Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[vesafb] Skip modes for which we cannot get mode information
The VirtualBox BIOS fails to retrieve mode information (with status
0x0100) for some modes within the mode list.  Skip any such modes,
rather than treating this as a fatal error.

Reported-by: Robin Smidsrød <robin@smidsrod.no>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Nov 28, 2013
1 parent 9678fed commit 405416e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/arch/i386/interface/pcbios/vesafb.c
Expand Up @@ -300,7 +300,7 @@ static int vesafb_select_mode ( unsigned int min_width, unsigned int min_height,
DBGC ( &vbe_buf, "VESAFB could not get mode %04x "
"information: [%04x] %s\n", mode_number,
status, strerror ( rc ) );
goto err_mode_info;
continue;
}
DBGC ( &vbe_buf, "VESAFB mode %04x %dx%d %dbpp(%d:%d:%d:%d) "
"model %02x [x%d]%s%s%s%s%s\n", mode_number,
Expand Down Expand Up @@ -348,7 +348,6 @@ static int vesafb_select_mode ( unsigned int min_width, unsigned int min_height,
}

err_set_mode:
err_mode_info:
free ( mode_numbers );
err_mode_list:
return rc;
Expand Down

0 comments on commit 405416e

Please sign in to comment.