Skip to content

Commit

Permalink
[nfs] Fix an issue with the selection of a local port
Browse files Browse the repository at this point in the history
Reported-by: Robin Smidsrød <robin@smidsrod.no>
Signed-off-by: Marin Hannache <git@mareo.fr>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
Mareo authored and mcb30 committed Aug 6, 2013
1 parent 252d28f commit 53c01d6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/net/oncrpc/nfs_open.c
Expand Up @@ -160,12 +160,12 @@ static int nfs_connect ( struct interface *intf, uint16_t port,
return -EINVAL;

memset ( &peer, 0, sizeof ( peer ) );
memset ( &peer, 0, sizeof ( local ) );
memset ( &local, 0, sizeof ( local ) );
peer.st_port = htons ( port );

/* Use a local port < 1024 to avoid using the 'insecure' option in
* /etc/exports file. */
local.st_port = htons ( 1 + ( rand() % 1023 ) );
local.st_flags = TCPIP_BIND_PRIVILEGED;

return xfer_open_named_socket ( intf, SOCK_STREAM,
( struct sockaddr * ) &peer, hostname,
Expand Down

0 comments on commit 53c01d6

Please sign in to comment.