Skip to content

Commit

Permalink
[zbin] Fix size used for memset in alloc_output_file
Browse files Browse the repository at this point in the history
The output->buf field is a pointer, not an array, so sizeof() is not
applicable.  We must use the allocated string length instead.

Identified by gcc:

  util/zbin.c: In function ‘alloc_output_file’:
  util/zbin.c:146:37: warning: argument to ‘sizeof’ in ‘memset’ call
    is the same expression as the destination; did you mean to
    dereference it? [-Wsizeof-pointer-memaccess]
  memset ( output->buf, 0xff, sizeof ( output->buf ) );

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
berrange authored and mcb30 committed Mar 5, 2013
1 parent 9373ca8 commit eb5a2ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/util/zbin.c
Expand Up @@ -143,7 +143,7 @@ static int alloc_output_file ( size_t max_len, struct output_file *output ) {
max_len );
return -1;
}
memset ( output->buf, 0xff, sizeof ( output->buf ) );
memset ( output->buf, 0xff, max_len );
return 0;
}

Expand Down

0 comments on commit eb5a2ba

Please sign in to comment.