Skip to content

Commit

Permalink
[build] Use -maccumulate-outgoing-args if required by gcc
Browse files Browse the repository at this point in the history
Current versions of gcc require -maccumulate-outgoing-args if any
sysv_abi functions call ms_abi functions.  This requirement is likely
to be lifted in future gcc versions, so test explicitly to see if the
current version of gcc requires -maccumulate-outgoing-args.

This problem is currently masked since the implied
-fasynchronous-unwind-tables (which is the default in current gcc
versions) implies -maccumulate-outgoing-args.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Nov 2, 2012
1 parent 6586e03 commit f008698
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/arch/x86_64/Makefile
Expand Up @@ -26,6 +26,18 @@ CFLAGS += -fshort-wchar
#
CFLAGS += -Ui386

# Add -maccumulate-outgoing-args if required by this version of gcc
#
ifeq ($(CCTYPE),gcc)
MS_ABI_TEST_CODE := extern void __attribute__ (( ms_abi )) ms_abi(); \
void sysv_abi ( void ) { ms_abi(); }
MS_ABI_TEST = $(ECHO) '$(MS_ABI_TEST_CODE)' | \
$(CC) -m64 -mno-accumulate-outgoing-args -x c -c - -o /dev/null \
>/dev/null 2>&1
MS_ABI_FLAGS := $(shell $(MS_ABI_TEST) || $(ECHO) '-maccumulate-outgoing-args')
WORKAROUND_CFLAGS += $(MS_ABI_FLAGS)
endif

# x86_64-specific directories containing source files
#
SRCDIRS += arch/x86_64/prefix
Expand Down

0 comments on commit f008698

Please sign in to comment.